Added support for calling TryValidateModel#54
Added support for calling TryValidateModel#54icnocop wants to merge 4 commits intoSharpGrip:masterfrom
Conversation
icnocop
force-pushed
the
TryValidateModel
branch
2 times, most recently
from
5654e44 to
945cab4
Compare
…erted into AggregateException
icnocop
force-pushed
the
TryValidateModel
branch
from
736f137 to
1daba17
Compare
| // If built in model validation is disabled return true for later validation in the action filter. | ||
| return disableBuiltInModelValidation || base.Validate(metadata, key, model, alwaysValidateAtTopLevel); | ||
| bool isBaseValid = disableBuiltInModelValidation || base.Validate(metadata, key, model, alwaysValidateAtTopLevel); | ||
| return ValidateAsync(isBaseValid, key, model).GetAwaiter().GetResult(); |
There was a problem hiding this comment.
@icnocop not sure about this one, won't this result in deadlocks?
There was a problem hiding this comment.
In ASP.NET Core, it should not cause a deadlock, according to ChatGPT 4.1.
In which scenario(s) are you thinking it could cause a deadlock?
Maybe a test can be written to verify it.
| private readonly bool disableBuiltInModelValidation; | ||
|
|
||
| public FluentValidationAutoValidationObjectModelValidator(IModelMetadataProvider modelMetadataProvider, IList<IModelValidatorProvider> validatorProviders, bool disableBuiltInModelValidation) | ||
| public FluentValidationAutoValidationObjectModelValidator( |
| IModelMetadataProvider metadataProvider, | ||
| ValidationStateDictionary? validationState) | ||
| { | ||
| return new FluentValidationAutoValidationValidationVisitor(actionContext, validatorProvider, validatorCache, metadataProvider, validationState, disableBuiltInModelValidation); |
| { | ||
| public static class FluentValidationHelper | ||
| { | ||
| public static async Task<ValidationResult?> ValidateWithFluentValidationAsync( |
There was a problem hiding this comment.
@icnocop this method feels kinda hacky by taking a IServiceProvider as an argument, what do you think?
There was a problem hiding this comment.
What else do you recommend?
IServiceProvider is needed to dynamically get the validator based on the type of the model.
|
@icnocop gave this one some more thought and I am afraid I am not going to include it as long as the current MVC validation pipeline is still not async. Let's revisit this issue when dotnet/aspnetcore#31905 lands. It is currently one of the top upvoted issue in the aspnet core repo so hopefully it makes the .NET 11 release. |
3 participants
Fixes #53